-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Added msrv to threadlocal initializer check #12405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! ❤️
@bors r+ |
Added msrv to threadlocal initializer check closes: #12404
💔 Test failed - checks-action_test |
@bors r+ |
💡 This pull request was already approved, no need to approve it again. |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
@rustbot label +beta-nominated |
…ulacrum [beta] Clippy backports Backports included in this PR: - rust-lang/rust-clippy#12276 Fixing the lint on some platforms before hitting stable - rust-lang/rust-clippy#12405 Respect MSRV before hitting stable - rust-lang/rust-clippy#12266 Fixing an (unlikely) ICE - rust-lang/rust-clippy#12177 Fixing FPs before hitting stable Each backport on its own might not warrant a backport, but the collection of those are nice QoL fixes for Clippy users, before those bugs hit stable. All of those commits are already on `master`. r? `@Mark-Simulacrum`
closes: #12404
changelog:[
thread_local_initializer_can_be_made_const
]: Check for MSRV (>= 1.59) before processing.