Clippy Book Chapter Updates Reborn: Lint Passes #10622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
llogiq
reviewed
Apr 10, 2023
book/src/development/lint_passes.md
Outdated
| that every Clippy developers must make: to use | ||
| [`EarlyLintPass`][early_lint_pass] or [`LateLintPass`][late_lint_pass]. | ||
|
|
||
| In short, the `LateLintPass` has access to type information while the |
There was a problem hiding this comment.
Not only type information but also resolve: In an early pass, you usually have no information what a symbol means, so most early lints are plainly syntactic.
There was a problem hiding this comment.
Fixed. (Talks about that in the introduction and in the "Early Lint Pass" section)
|
Thanks, I have a 12h flight ahead of me on Sunday, where I'll look at these PRs. |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
bors
added a commit
that referenced
this pull request
Aug 16, 2023
Clippy Book Chapter Updates Reborn: Method Checking This PR adds a new chapter to the book: "Method Checking". Some major re-phrasing was done and some changes in the code comments (apart from grammar and minor changes). ## Notes - Requires #10595 **and** #10622 to be merged before this, or else several links will be broken - To talk about the whole project, please use the tracking issue for the project #10597 (It also contains a timeline, discussions and more information) changelog: Add a new "Method Checking" chapter to the book. r? `@flip1995`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new chapter to the book: "Lint passes". No major changes apart from some re-phrasing, fixing typos... etc.
Notes
changelog: Add a new "Lint passes" chapter to the book
r? @flip1995