Macros: Split in topics, use playpen and cover more topics #193
Conversation
|
I'll look at it but I may not get to it for a day or 2. Not sure. |
Thanks in advance! |
| * `path` | ||
| * `stmt` | ||
| * `tt` (*token tree*) is used for operators (`+`, `-`, etc) | ||
| * `ty` (*type*) |
There was a problem hiding this comment.
It does make sense to only explain the common ones but having most of them blank here looks really weird. A brief description might be in order. Also, that Macro by example page still doesn't describe them so linking to it won't be of much help.
|
|
||
| * `block` | ||
| * `expr` is used for expressions | ||
| * `ident` is used for variable/function names |
There was a problem hiding this comment.
I think it's worth adding (*identifier*) here. Same with for expr, pat and stmt. Note: I actually have no idea what stmt is.
There was a problem hiding this comment.
stmt (statement)(from IRC)pat (pattern)(not sure though...asked on IRC and got no reply)matchers (lhs of the => in macro rules)(from manual)tt (rhs of the => in macro rules)(from manual;token treefrom IRC)
|
This has stalled...I think you should:
|
|
@japaric , I'm assuming you're not interested in updating this PR, is that correct? |
Correct. I'm closing this to clear the queue. |
I've rebased #185 and done a few changes. I'm satisfied with the current examples and the contents, but the wording could be further improved.
We are still missing the topic on how to export macros to be able to close #110
@mdinger I hope you can review the changes