Fs fix 2880 #4483
Closed
Fs fix 2880 #4483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, the problem with these instructions is that since then, Chalk has started adding built-in impls, so now that is the place where built-in impls should be added. The ones on the rust-analyzer side are likely to get removed as soon as we have them in Chalk. We could still merge this, but it will probably be removed soon. As to why it doesn't work, I would try adding a test with a similar |
|
ok, I will close this one then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to fix #2880 mostly following @flodiebold's instructions. While this fixes the testcase that is being added in this PR, it does not fix the situation described in the respective issue. My guess is that it has to do with the type parameter having a default value and I am now trying to boil it down to the minimal testcase. Any ideas on that?
Fixes #2880