Implement expand_task and list_macros in proc_macro_srv #3920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
reviewed
Apr 9, 2020
edwin0cheng
force-pushed
the
impl-proc-macro-srv
branch
from
7383503 to
197039b
Compare
lnicola
reviewed
Apr 10, 2020
matklad
reviewed
Apr 10, 2020
| difference = "2.0.0" | ||
| # used as proc macro test target | ||
| serde_derive = "=1.0.104" | ||
| serde_derive = "=1.0.104" |
There was a problem hiding this comment.
Hm, why we use an = dep here?
There was a problem hiding this comment.
It is because we want to lock the version of proc macro to test with. They would change whatSerialize to expand which may change the test result.
matklad
reviewed
Apr 10, 2020
matklad
reviewed
Apr 10, 2020
lnicola
reviewed
Apr 10, 2020
|
I changed to use std::io::Error for all dylib loading code and fixed other nits too. |
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finish up the remain
proc_macro_srvimplementation :Added dylib loading code for proc-macro crate dylib. Note that we have to add some special flags for unix loading because of a bug in old version of glibc, see Some notes about the panic fedochet/rust-proc-macro-panic-inside-panic-expample#1 and Panic inside panic when procedural macro is called with proc_macro::bridge::client rust#60593 for details.
Added tests for proc-macro expansion: We use a trick here by adding
serde_deriveto dev-dependencies and callingcargo-metadatafor searching its dylib path, and expand it in our tests.[EDIT]
Note that this PR DO NOT implement the final glue code with rust-analzyer and proc-macro-srv yet.