Skip to content

Add render associated constant in notable trait #21152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add render associated constant in notable trait #21152

wants to merge 1 commit into from

Conversation

@A4-Tacks
Copy link
Member

@A4-Tacks A4-Tacks commented Nov 28, 2025

Example

impl Notable for u32 {
    type Assoc = &str;
    type Assoc2 = char;
    const ID: u32 = 3;
}

Before this PR

Implements notable traits: `Notable<Assoc = &str, Assoc2 = char>`

After this PR

Implements notable traits: `Notable<Assoc = &str, Assoc2 = char, ID = 3>`

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 28, 2025
@A4-Tacks A4-Tacks force-pushed the render-notable-assoc-const branch from 6ef77a6 to 4dc5cf8 Compare November 28, 2025 06:09
@A4-Tacks A4-Tacks marked this pull request as draft November 28, 2025 06:19
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 28, 2025
@A4-Tacks A4-Tacks marked this pull request as ready for review November 28, 2025 09:13
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 28, 2025
@A4-Tacks A4-Tacks force-pushed the render-notable-assoc-const branch from 4dc5cf8 to ca2df25 Compare November 28, 2025 09:13
@A4-Tacks
Add render associated constant in notable trait
b161e8b 
Example
---
```rust
impl Notable for u32 {
    type Assoc = &str;
    type Assoc2 = char;
    const ID: u32 = 3;
}
```

**Before this PR**

```text
Implements notable traits: `Notable<Assoc = &str, Assoc2 = char>`
```

**After this PR**

```text
Implements notable traits: `Notable<Assoc = &str, Assoc2 = char, ID = 3>`
```
@A4-Tacks A4-Tacks force-pushed the render-notable-assoc-const branch from ca2df25 to b161e8b Compare November 28, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@A4-Tacks @rustbot