refactor: merge_imports and unmerge_imports to editor
#19469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
approved these changes
Apr 22, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
snprajwal
changed the title
merge_imports to syntax editormerge_imports and unmerge_imports to editor
Also ensures that attributes on the use item are applied to the new use item when unmerging. Signed-off-by: Prajwal S N <[email protected]>
Signed-off-by: Prajwal S N <[email protected]>
Co-authored-by: Tarek <[email protected]> Signed-off-by: Prajwal S N <[email protected]>
snprajwal
force-pushed
the
merge-imports
branch
from
6eb3f2f to
d25c175
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #18285, and supersedes #18484.
Needs rebase after #19465 is merged.
cc @darichey again, thanks for the reviews!