Skip to content

hir: resolve assoc trait type in path #10896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 1, 2021

Conversation

jhgg
Copy link
Contributor

@jhgg jhgg commented Dec 1, 2021

fixes #9802

  • write tests, maybe, if this is even a good fix...

@jhgg jhgg changed the title hir: resolve assoc trait type hir: resolve assoc trait type in path Dec 1, 2021
@Veykril
Copy link
Member

Veykril commented Dec 1, 2021

Can you add something to the highlighting test here that verifies that the resolution works? https://github.com/rust-analyzer/rust-analyzer/blob/2d0db312b543343f1c208b6be21a7a001cec7dd6/crates/ide/src/syntax_highlighting/tests.rs#L10
bors d+

@bors
Copy link
Contributor

bors bot commented Dec 1, 2021

✌️ jhgg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@jhgg
Copy link
Contributor Author

jhgg commented Dec 1, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 1, 2021

@bors bors bot merged commit c5ad6c8 into rust-lang:master Dec 1, 2021
@jhgg jhgg deleted the hir/resolve-trait-assoc-type branch December 1, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[semantic tokens] unresolvedReference in trait associated type
2 participants