Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Reenable lens test #948

Closed
wants to merge 1 commit into from
Closed

Reenable lens test #948

wants to merge 1 commit into from

Conversation

matklad
Copy link
Member

@matklad matklad commented Jul 18, 2018

Let's just see if this reliably passes CI

@matklad
Copy link
Member Author

matklad commented Jul 18, 2018

One round of CI was successful. Updating the PR to trigger another one.

@nrc
Copy link
Member

nrc commented Jul 19, 2018

The lens test was failing intermittently inside Rust. To test that you'll need to pull this branch into the RLS submodule and then .x.py test src/tools/rls.

It was non-deterministic. We've tried to eradicate some sources of
non-determinism recently, let's check if it fixes the test.
@matklad
Copy link
Member Author

matklad commented Jul 19, 2018

Looks like current master of RLS does not exactly work with rust-lang/rust :-)

error: process didn't exit successfully: /home/matklad/projects/rust/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/rls-3ec593da9fd41bf7 (signal: 4, SIGILL: illegal instruction)

@matklad
Copy link
Member Author

matklad commented Jul 20, 2018

Closed in favor of #952

SIGILL thing is #951

@matklad matklad closed this Jul 20, 2018
@matklad matklad deleted the check-test branch July 20, 2018 13:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants