This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Remove intermittent failing test #532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `bin_lib_project` and `bin_lib_project_no_cfg` tests can intermittently fail when run in parallel, especially when running them in the rustc x.py tests. This commit temporarily removes one of those tests. The test is still legitimate, but we need to find a way to be able to use the same test project directory (lib_bin) in tests, and make sure that they work when testing in the CI environment.
|
If this will relieve tests over at rustc then sure, but I'm getting increasingly anxious about these reverts/test issues. I'll take a closer look to see what's causing it and if we can do better. Thanks! cc @nrc |
|
@Xanewok I agree about reinstating this test (and others) as soon as we have a fix. I've done some researching, but I still don't have a solution for it yet. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bin_lib_projectandbin_lib_project_no_cfgtests can intermittently fail when run in parallel, especially when running them in the rustc x.py tests. This commit temporarily removes one of those tests. The test is still legitimate, but we need to find a way to be able to use the same test project directory (lib_bin) in tests, and make sure that they work when testing in the CI environment.See #524.