Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Update Step trait implementation #1738

Merged
merged 1 commit into from
May 30, 2021
Merged

Update Step trait implementation #1738

merged 1 commit into from
May 30, 2021

Conversation

jhpratt
Copy link
Member

@jhpratt jhpratt commented May 30, 2021

Closes rust-lang/rust#85824

This replaces the unsafe impl Step with impl Step and unsafe impl TrustedStep. This is the only location of the Step trait in this repository.

@Xanewok
Copy link
Member

Xanewok commented May 30, 2021

LGTM, thanks!

@bors r+

@bors
Copy link
Contributor

bors commented May 30, 2021

📌 Commit 30660c7 has been approved by Xanewok

@bors
Copy link
Contributor

bors commented May 30, 2021

⌛ Testing commit 30660c7 with merge 12a5fd2...

bors added a commit that referenced this pull request May 30, 2021
Update `Step` trait implementation

Closes rust-lang/rust#85824

This replaces the `unsafe impl Step` with `impl Step` and `unsafe impl TrustedStep`. This is the only location of the `Step` trait in this repository.
@jhpratt
Copy link
Member Author

jhpratt commented May 30, 2021

Build failure looks completely unrelated.

@Xanewok
Copy link
Member

Xanewok commented May 30, 2021

Ah right, I forgot about the Rustfmt bump; I'll merge this manually. Thanks again!

@Xanewok Xanewok merged commit 0b93c50 into rust-lang:master May 30, 2021
@calebcartwright
Copy link
Member

I've got a PR on the way with the bumps @Xanewok

@jhpratt jhpratt deleted the update-step-trait branch May 30, 2021 23:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rls no longer builds after rust-lang/rust#83772
4 participants