Update pub(in path) for 2018. #480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When updating paths, I neglected to add a note that visibility paths must be absolute.
src/visibility-and-privacy.md
Outdated
| @@ -154,13 +154,18 @@ be a parent module of the item whose visibility is being declared. | |||
| - `pub(self)` makes an item visible to the current module. This is equivalent | |||
| to `pub(in self)`. | |||
|
|
|||
| > **Edition Differences**: Starting with the 2018 edition, paths for | |||
| > `pub(in path)` must start with `crate`, `self`, or `super`. | |||
There was a problem hiding this comment.
Isn't this just a consequence of the path having to be absolute?
There was a problem hiding this comment.
Yes, but there is nothing else that explicitly calls that out for visibility paths. The only other part is the "use declarations", which only talk about the requirements in use declarations. Or are you saying it should be worded differently?
There was a problem hiding this comment.
I didn't realise how the reference described paths in use items. The wording here is probably fine, but I think that there should be some wording on how paths that start with an identifier are resolved in the 2015 edition.
matthewjasper
approved these changes
Dec 17, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating paths, I neglected to add a note that visibility paths must
be absolute.