Reduce wasm test suite #96
Conversation
workingjubilee
force-pushed
the
burning-chrome
branch
from
ac83408 to
fff0507
Compare
|
Doesn't this have nothing to do with chrome? It's failing because of wasm-bindgen, not chrome per #92 |
workingjubilee
force-pushed
the
burning-chrome
branch
2 times, most recently
from
20658f5 to
a40f110
Compare
|
I guess? I don't fully understand the wasm toolchain yet. |
|
This is where the error occurs: https://github.com/rustwasm/wasm-bindgen/blob/master/crates/cli/src/bin/wasm-bindgen-test-runner/main.rs#L69-L70 |
workingjubilee
force-pushed
the
burning-chrome
branch
2 times, most recently
from
38a4491 to
f10e390
Compare
|
me checking the phone after work "why am i being emailed about a Gibson novel?" |
workingjubilee
force-pushed
the
burning-chrome
branch
from
d6c3166 to
afc9d72
Compare
|
Latest trunk of wasm-bindgen doesn't appear to fix it. |
workingjubilee
force-pushed
the
burning-chrome
branch
from
afc9d72 to
81c9633
Compare
|
I have come around to your point of view, @calebzulawski, and so have omitted the wasm SIMD test suite. I still dropped Chrome because I would rather test on the latest (beta) Chrome and Travis + ChromeDriver security features appear to make that hard for us, so I suspect we will have slightly fewer issues with our test suite failing to connect to the headless browser with GeckoDriver. |
Fighting CI over #92.
Node is removed from CI because it was apparently never actually being tested: when I ran the test suite locally, it appeared to skip all the tests. Chrome is removed from CI because Chrome Beta drops connections more often and Firefox Nightly allows us to test on the latest Firefox.
Something still fails inside wasm-bindgen, so I omitted the relevant tests.