-
Notifications
You must be signed in to change notification settings - Fork 385
rustup for big refactor; kill most of validation #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Argh, again new new nightly :( |
This now fixes the compile-fail tests for memory leaks and mutating statics. :) It also gets rid of some hacks that hook some arbitrary functions even though they have MIR... I will probably pay for this by breaking macOS and/or Windows. Let's see. |
(Just experimenting with AppVeyor) |
We finally have a nightly with the refactorings this matches, so I am going to try and make CI pass. Otherwise I think this is ready for review. @oli-obk do you want be to rebase and maybe squash a little? We ended up backing out the miri updates, so I think none of the commits here is actually ever referenced from rustc. The only actually functional changes in this PR are:
|
squashing/rebasing seems fine to me, but not necessary |
Well then I'd say let's get this merged. CI is green. Waiting for your r+ :) |
@@ -293,15 +210,15 @@ pub struct Evaluator<'tcx> { | |||
/// Miri does not expose env vars from the host to the emulated program | |||
pub(crate) env_vars: HashMap<Vec<u8>, Pointer>, | |||
|
|||
/// Places that were suspended by the validation subsystem, and will be recovered later | |||
pub(crate) suspended: HashMap<DynamicLifetime, Vec<ValidationQuery<'tcx>>>, | |||
/// Use the lifetime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lolwat? Are you going to need it again in the future? Or why not just remove it? Too much churn?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean remove the lifetime? Hm, I didn't remember adding it so I just did not touch it.^^ But also indeed I am not sure yet which extra data I will add again for the Stacked Borrows stuff.
Do not force-push, rustc refers to this commit with rust-lang/rust#53424
Fixes #382
Fixes #439