-
Notifications
You must be signed in to change notification settings - Fork 386
add support for #[global_allocator]
#1885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What is the difference between your test and the code in the issue that causes the failure? What kind of failure are we talking about? A stacked borrows failure? |
Yeah, |
e30c8a0
to
f40451c
Compare
Right, rustfmt refuses to work correctly on |
Interesting, I did not know this. Yeah might be good to report that with rustfmt. |
This looks great. :) Could you squash the commits a bit? |
9b722c1
to
e6a27a6
Compare
I squashed the commits up. |
Awesome, thanks a lot. :) @bors r+ |
📌 Commit e6a27a6 has been approved by |
☀️ Test successful - checks-actions |
This PR adds support for custom global allocators. Unfortunately, the code given in #1207 still causes errors when used with box. I believe this is because Box is special-cased in miri and stacked borrows.