rustup; fix tests for new MIR optimization #1729
Conversation
|
@bors r+ |
|
📌 Commit 2ef3338 has been approved by |
rustup; fix tests for new MIR optimization Somehow rust-lang/rust#78360 manages to mask UB. This would make sense if there were loops or things like that, but there are not, so really this is just very confusing...
| @@ -27,9 +28,6 @@ pub fn main() { | |||
| // 3. stack-deallocate | |||
| unsafe { | |||
| let j1 = spawn(move || { | |||
| // Concurrent allocate the memory. | |||
| // Uses relaxed semantics to not generate | |||
| // a release sequence. | |||
There was a problem hiding this comment.
@JCTyblaidd these comments seem to be wrong here; there is no allocation and also nothing relaxed anywhere nearby...
| @@ -38,6 +36,8 @@ pub fn main() { | |||
|
|
|||
| sleep(Duration::from_millis(200)); | |||
|
|
|||
| // Now `stack_var` gets deallocated. | |||
There was a problem hiding this comment.
@JCTyblaidd I think this is right, would be good to check.
|
|
||
| sleep(Duration::from_millis(200)); | ||
|
|
||
| drop(stack_var); |
There was a problem hiding this comment.
@JCTyblaidd I removed this file since the drop here seems to be the only difference... but drop on an integer does nothing, and drop is just a normal function, so I really don't understand the purpose of this.^^
|
@bors r- |
tests/compile-fail/sync/libc_pthread_rwlock_read_write_deadlock_single_thread.rs
Show resolved
Hide resolved
|
@bors r+ |
|
📌 Commit 97e45e0 has been approved by |
|
☀️ Test successful - checks-actions |
Somehow rust-lang/rust#78360 manages to mask UB. This would make sense if there were loops or things like that, but there are not, so really this is just very confusing...