Sidebar improvements #2666
Open
Sidebar improvements #2666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 15, 2025 12:30
Sidebar status is now moved to sessionStorage. Fix: sidebar visibility was not correctly loaded from storage when the browser window was smaller than 1080 pixels wide. Sidebar width is now saved too. Remove too large try-catch block that would hide some errors.
does not interact with it.
Fix: actually in the original code, only two entries were stripped of their (potential) quotes: "mdbook-theme" and "mdbook-sidebar". Since now we store sidebar config in sessionStorage, and it cannot contain legacy values, only "mdbook-theme" needs to be stripped of its quotes, and if getConfig() is meant to be used more generally, it must not silently do that to *every* value it reads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sidebar status is now moved to sessionStorage instead of localStorage.
Fix: sidebar visibility was not correctly loaded from storage when the browser window was smaller than 1080 pixels wide.
Sidebar width is now saved too.
Remove too large try-catch block that would hide some errors.
Resolves #2665