Speed up search index loading #2633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
force-pushed
the
speed-up-loading
branch
from
c40477c to
016f41c
Compare
GuillaumeGomez
force-pushed
the
speed-up-loading
branch
from
016f41c to
7acc7a0
Compare
|
Forgot to update the tests for loading the new JSON format, it's done fixed. |
|
@ehuss Did you have time to take a look? Do you need some extra explanations on the changes maybe? |
ehuss
approved these changes
Apr 21, 2025
There was a problem hiding this comment.
Thanks! I haven't done any performance tests, but I assume it should be ok.
Just to be sure: does this PR solves your 10+ seconds issue for search load?
No, the concern was just around a low-bandwidth network connection trying to load a very large index. That's purely a network constraint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #2552.
JSON.parse()is much faster than parsing JS code for JS engines. I missed this case when I removed the original JSON file. This is also how we do in rustdoc. The bigger the search index, the more noticeable it is.As for the second commit, it fixes this JS error:
@ehuss Just to be sure: does this PR solves your 10+ seconds issue for search load?