Skip to content

elevate the log level of calling a preprocessor to info #2621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

szabgab
Copy link
Contributor

@szabgab szabgab commented Mar 28, 2025

To be the same as for the backends.

To be the same as for the backends.
@rustbot rustbot added the S-waiting-on-review Status: waiting on a review label Mar 28, 2025
@ehuss
Copy link
Contributor

ehuss commented Mar 31, 2025

Hm, I'm a little reluctant to change this since I think mdbook is already too noisy, and the important things can be lost in the output. Can you say more about what kind of scenarios where this would be useful to know?

@szabgab
Copy link
Contributor Author

szabgab commented Apr 1, 2025

It is strange to me that you say it is too noisy, when I run mdbook build I only get two lines of output:

2025-04-01 07:39:15 [INFO] (mdbook::book): Book building has started
2025-04-01 07:39:15 [INFO] (mdbook::book): Running the html backend

Making the above change would add 2 more lines to this output.
Of course when there are more preprocessors and more output generators then the numbers multiply and when I run mdbook serve then I see all these lines on every change, so you might be right that it gets too noisy.

I needed this change when I was trying to figure out what's going on in a book that had

[preprocess.links]

(instead of [preprocessor.links])

I also felt the level of logging should be the same for all the plugins.

Maybe we need to demote the "Running the html backend" do debug and instead of that add a "Book building has finished". And maybe we need some way to see when the plugins run without seeing all the "debug" messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: waiting on a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants