Correct the function signatures for getpriority/setpriority #4458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
__priority_which_t
type was incorrectly exposed as a type alias and defined as unsigned when they should be signed.Description
This CL removes the
__priority_which_t
type alias from theunix::linux_like::linux::gnu
module. It is not used for the same purpose as in the C++ source (enum value definition) and it is not supposed to be exposed to the user (seeman setpriority
). The type signatures forgetpriority
andsetpriority
are then updated to use the correctc_int
type.Sources
Libc source references:
*https://github.com/bminor/glibc/blob/4052d99ead880797cf271309fd87ddd2b95bd353/resource/sys/resource.h#L105
C++ Standard Reference:
int
: https://en.cppreference.com/w/cpp/language/enumChecklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see rust-lang/libc#3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI
Compilation error when running
cargo test --target x86_64-unknown-linux-gnu
:This does not appear to be caused by this PR.