Add strftime* for illumos. #4453
Open
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
changed the title
|
Any chance to get this added also for Solaris? This should be common for both Illumos and Solaris. |
devnexen
force-pushed
the
gh4449
branch
2 times, most recently
from
eed2acb to
40673d5
Compare
tgross35
requested changes
May 14, 2025
|
Seems like it, I ll have a look later today. |
pfmooney
reviewed
May 14, 2025
src/unix/solarish/mod.rs
Outdated
| @@ -3202,6 +3202,21 @@ extern "C" { | |||
| pub fn arc4random_uniform(upper_bound: u32) -> u32; | |||
|
|
|||
| pub fn secure_getenv(name: *const c_char) -> *mut c_char; | |||
|
|
|||
| #[link_name = "__xpg4_strftime"] | |||
There was a problem hiding this comment.
Doing this unconditionally for both Solaris and illumos is going to break the latter, I believe.
There was a problem hiding this comment.
in fact I m just trying to see if it fixes solaris case :) thus this PR being a draft for now
There was a problem hiding this comment.
@pfmooney would you be able to check the current version?
devnexen
force-pushed
the
gh4449
branch
2 times, most recently
from
283f069 to
237d749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref
Fixes: #4449