Skip to content

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Apr 14, 2025

This PR is a part of the #4406 per @tgross35 suggestion

  • Remove Cargo settings that are identical to the defaults (per Cargo recommendations)
  • Fix perl-based method to extract MSRV
  • Note that the order of the values is such as to make it easier to switch to the inherited ones from workspace once MSRV is bumped

@rustbot label +stable-nominated

* Remove Cargo settings that are identical to the defaults (per Cargo [recommendations](https://doc.rust-lang.org/cargo/reference/manifest.html))
* Fix perl-based method to extract MSRV
@rustbot
Copy link
Collaborator

rustbot commented Apr 14, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-CI Area: CI-related items ctest Issues relating to the ctest crate S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Apr 14, 2025
@tgross35
Copy link
Contributor

Thanks!

@tgross35 tgross35 enabled auto-merge April 14, 2025 19:42
@nyurik
Copy link
Contributor Author

nyurik commented Apr 14, 2025

This is weird - FreeBSD-13 / nightly keeps failing with a seg fault - https://cirrus-ci.com/task/5609497042878464?logs=test#L300 ... Was this ever a problem before? Note that there is no code changes...

+ cargo test --target i686-unknown-freebsd --workspace --features extra_traits -- --skip check_style
Segmentation fault (core dumped)

@tgross35 tgross35 added this pull request to the merge queue Apr 14, 2025
@tgross35
Copy link
Contributor

FreeBSD 13 has a spurious segfault, unrelated to this change of course. It may be related to #3998 but I'm not sure why it isn't consistent.

Merged via the queue into rust-lang:main with commit f199d07 Apr 14, 2025
47 checks passed
@nyurik nyurik deleted the cargo-simple branch April 14, 2025 20:25
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request May 28, 2025
* Remove Cargo settings that are identical to the defaults (per Cargo [recommendations](https://doc.rust-lang.org/cargo/reference/manifest.html))
* Fix perl-based method to extract MSRV

(cherry picked from commit d8e39a2)
(backport <rust-lang#4408>)
@tgross35 tgross35 mentioned this pull request May 28, 2025
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request May 28, 2025
* Remove Cargo settings that are identical to the defaults (per Cargo [recommendations](https://doc.rust-lang.org/cargo/reference/manifest.html))
* Fix perl-based method to extract MSRV

(backport <rust-lang#4408>)
(cherry picked from commit d8e39a2)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Jun 1, 2025
DorianNiemiecSVRJS pushed a commit to DorianNiemiecSVRJS/rust-libc that referenced this pull request Jun 21, 2025
* Remove Cargo settings that are identical to the defaults (per Cargo [recommendations](https://doc.rust-lang.org/cargo/reference/manifest.html))
* Fix perl-based method to extract MSRV

(backport <rust-lang#4408>)
(cherry picked from commit d8e39a2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Area: CI-related items ctest Issues relating to the ctest crate S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants