Skip to content

Define SO_INCOMING_CPU for i686-unknown-linux-musl #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2021
Merged

Define SO_INCOMING_CPU for i686-unknown-linux-musl #2124

merged 1 commit into from
Mar 26, 2021

Conversation

fbecart
Copy link
Contributor

@fbecart fbecart commented Mar 26, 2021

Following the examples from #2119 and #2123, to fix the same issue with socket2: rust-lang/socket2#213

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

JohnTitor
JohnTitor approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be great if we could clean-up this at some point but I'm fine to add it to each arch + bits for now.

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 26, 2021

📌 Commit 24c1530 has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Mar 26, 2021

⌛ Testing commit 24c1530 with merge 2b51773...

bors added a commit that referenced this pull request Mar 26, 2021
@bors
Auto merge of #2124 - fbecart:master, r=JohnTitor
2b51773 
Define SO_INCOMING_CPU for i686-unknown-linux-musl

Following the examples from #2119 and #2123, to fix the same issue with `socket2`: rust-lang/socket2#213
@bors
Copy link
Contributor

bors commented Mar 26, 2021

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Mar 26, 2021

⌛ Testing commit 24c1530 with merge c5357c9...

@bors
Copy link
Contributor

bors commented Mar 26, 2021

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing c5357c9 to master...

@bors bors merged commit c5357c9 into rust-lang:master Mar 26, 2021
@decathorpe decathorpe mentioned this pull request Mar 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@Amanieu Amanieu

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fbecart @rust-highfive @JohnTitor @bors @Amanieu