Define missing F_RDLCK, F_WRLCK and F_UNLCK constants on linux-mips -and s390x #1186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are defined in the fcntl.h glibc header on MIPS systems on Linux but missing in the libc crate, so add them as they are required for the file locking API in rustc.
These are defined in the fcntl.h glibc header on s390x systems on Linux but missing in the libc crate, so add them as they are required for the file locking API in rustc.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ |
|
📌 Commit 63d1a8c has been approved by |
bors
added a commit
that referenced
this pull request
Dec 26, 2018
Define missing F_RDLCK, F_WRLCK and F_UNLCK constants on linux-mips -and s390x These are defined in the fcntl.h glibc header on MIPS and s390x systems on Linux but missing in the libc crate, so add them as they are required for the file locking API in rustc.
|
☀️ Test successful - status-appveyor, status-travis |
|
@alexcrichton Could you make a new release so we can use the updated |
|
Sure thing, release instructions are in the README! |
|
Ah, thanks for the pointer. Never done this before :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are defined in the fcntl.h glibc header on MIPS and s390x
systems on Linux but missing in the libc crate, so add them as they
are required for the file locking API in rustc.