jobserver fd_check: Allow sockets. #117
Conversation
I agree with the creator of issue rust-lang#6 that jobserver fds should be allowed to be sockets as well as pipes. A project I'm working on uses a jobserver implemented over Unix domain sockets.
|
Can add some details ; I already have a piece of software running that creates a token pool across all builds on the local machine using an abstract unix domain socket. It works well with GNU Make, Ninja and gcc. |
|
I'm more than willing to contribute, and to consider alternative approaches. |
NobodyXu
left a comment
NobodyXu
left a comment
There was a problem hiding this comment.
I'm not a maintainer of jobserver though I did have some contributions and subscribe to updates to jobserver closely and is a maintainer of cc, which use jobserver, so take my comment with a grain of salt.
And I'm not sure if I should merge the PR here on behalf of the maintainer, so probably not unless nobody has time to review it
| FromEnvErrorInner::CannotOpenFd(..) => FromEnvErrorKind::CannotOpenFd, | ||
| FromEnvErrorInner::NegativeFd(..) => FromEnvErrorKind::NegativeFd, | ||
| FromEnvErrorInner::NotAPipe(..) => FromEnvErrorKind::NotAPipe, | ||
| FromEnvErrorInner::NotAPipeOrSocket(..) => FromEnvErrorKind::NotAPipeOrSocket, |
There was a problem hiding this comment.
This would probably be an undesired breaking change, don't think we can rename this enum variant which is unfortunate
Could add a NotASocket
2 participants
I agree with the creator of issue #6 that jobserver fds should be allowed to be sockets as well as pipes. A project I'm working on uses a jobserver implemented over Unix domain sockets.