-
Notifications
You must be signed in to change notification settings - Fork 63
Conversation
=== stdout === === stderr === ==============
@matthiaskrgr any idea what's going on here? I cannot make sense of this
|
Is it actually fixed? Or does glacier report wrongly? |
On the current nightly it doesn't ICE, so glacier is correctly reporting it I would say. But it's flipping between fixed/not fixed on various nightlies so tomorrow who knows |
The Ok/ICE output was from me testing manually, I don't think it's nondeterministic either as I got the same results twice |
Interesting, it's worth reporting it to upstream and maybe adding a regression test quickly 🤔 |
Tested on UI tests on rust-lang/rust and yes, it seems fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this since it's flaky
…rrors,oli-obk Add regression test for rust-lang#96395 Closes rust-lang#96395 This repeats "fixed" and "ICE", see rust-lang/glacier#1243 (comment) I think it's good to add a test before regressing again. r? `@compiler-errors` for quick reviiew cc `@oli-obk` you might want to check as you're familiar with MIR
…rrors,oli-obk Add regression test for rust-lang#96395 Closes rust-lang#96395 This repeats "fixed" and "ICE", see rust-lang/glacier#1243 (comment) I think it's good to add a test before regressing again. r? ``@compiler-errors`` for quick reviiew cc ``@oli-obk`` you might want to check as you're familiar with MIR
Issue: rust-lang/rust#96395