rename param arr_length->num_values in gcc_jit_context_new_struct_con… #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…structor function
antoyo
approved these changes
Jan 26, 2025
|
Could you please also fix the CI script here to use |
|
I changed it to gcc-15 but caused other problems. What's the problem? |
|
Oh, you also need to change this line to use |
|
It's okay to be merged now. |
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using
gcc_jit_context_new_struct_constructorfunction that i realized there is small difference between the param name and gccjit's reference. It does not affect any other part of the project so merging is safe.Reference:
https://gcc.gnu.org/onlinedocs/jit/topics/expressions.html#c.gcc_jit_context_new_struct_constructor