chore: replace all internal usage of pin_mut #2941
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
rustbot
added
A-executor
|
We have some MSRV as |
Signed-off-by: tison <[email protected]>
tisonkun
force-pushed
the
replace--all-usage-of-pin-mut
branch
from
5689b48 to
b6a2a53
Compare
Signed-off-by: tison <[email protected]>
tisonkun
force-pushed
the
replace--all-usage-of-pin-mut
branch
from
22f9836 to
5b61de3
Compare
|
Thanks! Considering that all of the affected code except futures-executor/src/local_pool.rs and futures-util/src/future/future/mod.rs are tests, it might be a good idea to split those two into a separate PR. In that case, the changes to the tests would not affect the MSRV, so we can backport these right in. |
taiki-e
reviewed
Apr 5, 2025
| @@ -27,7 +26,7 @@ mod fuse; | |||
| mod map; | |||
|
|
|||
| delegate_all!( | |||
| /// Future for the [`flatten`](super::FutureExt::flatten) method. | |||
There was a problem hiding this comment.
Please split unrelated changes into separate PRs as they will be difficult to review.
|
OK. I'll submit two separated PRs. |
This was referenced Apr 5, 2025
taiki-e
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up #2929 (comment) step 2.
cc @taiki-e
We don't use a unified MSRV. So I'm understanding which versions should be updated.
This refers to #2924