Skip to content

adding loop_fn back to futures-rs, 0.3 intial implementation #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

adding loop_fn back to futures-rs, 0.3 intial implementation #2445

wants to merge 1 commit into from

Conversation

warlord500
Copy link

@warlord500 warlord500 commented May 15, 2021 •
edited by taiki-e
Loading

so this an attempt to add loop_fn back in again right now there are a few issues one.

  • add docs to struct without warnings!
  • add at least one working test!
  • change doc test
  • fix atomic_cas_target.rs
    this was done so i could get the code to build.

thanks to @ibraheemdev for helping me get rid of unsafe!!

Closes #2444

@warlord500 warlord500 requested a review from taiki-e as a code owner May 15, 2021 04:43
@taiki-e taiki-e added the A-future Area: futures::future label May 15, 2021
taiki-e
taiki-e reviewed May 27, 2021
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! As said in #2444, I would prefer not to add this unless there is a specific use case that requires this.

@taiki-e taiki-e closed this May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e left review comments

Assignees
No one assigned
Labels
A-future Area: futures::future
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adding loop_fn_back in to the future-rs
2 participants
@warlord500 @taiki-e