Non-Send boxed() #1563
Merged
Non-Send boxed() #1563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dealing with the same issue here. @cramertj Is it possible to simply revert the |
|
The CI failure is related to #1555 and rust-lang/rust#60289, I'm looking into a fix for it. EDIT: Opened #1564 to track it. |
Nemo157
reviewed
Apr 27, 2019
miquels
added a commit
to miquels/webdav-handler-rs
that referenced
this pull request
Apr 30, 2019
In futures 0.3.alpha15, the .boxed() helper added a Send trait bound. As we don't need that, use Box::pin instead. alpha16 will likely have a .boxed_local() helper. See also rust-lang/futures-rs#1563
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds non-
Sendversions ofBoxFutureandboxed(), prompted by theSendrequirement in #1494 (and thus the latest release) breaking some of our code. This allows avoiding unnecessarySendbounds in generic-heavy code.