Skip to content

Conversation

syphar
Copy link
Member

@syphar syphar commented Sep 12, 2025

I'm starting on some refactoring tasks to make many thing more readable and easier to manage.

rusqlite became annoying to manage because sqlx & rusqlite want to link to different versions of the sqlite library.
The really cool features that rusqlite has are unused by us, and we don't need them in the near future.

Like this we can use the same (sqlx) way of doing things with the archive index.

On top of that this also some methods async, though in case of sqlx-sqlite it doesn't make a real difference because sqlx uses a background thread and then still has to do the syncronous sqlite FFI. And I would say that there is not really a big difference between its own background thread, or tokio's spawn_blocking.

While I was on it I used the sqlx QueryBuilder to batch the INSERT statements when we create the index.

@syphar syphar self-assigned this Sep 12, 2025
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Sep 12, 2025
@syphar syphar changed the title remove rusqlite remove separate sqlite dependency with async sqlx-sqlite Sep 12, 2025
@syphar syphar changed the title remove separate sqlite dependency with async sqlx-sqlite WIP: remove separate sqlite dependency with async sqlx-sqlite Sep 12, 2025
@syphar syphar changed the title WIP: remove separate sqlite dependency with async sqlx-sqlite WIP: replace separate sqlite dependency with async sqlx-sqlite Sep 12, 2025
@syphar syphar changed the title WIP: replace separate sqlite dependency with async sqlx-sqlite WIP: replace separate sqlite dependency with async sqlx-sqlite, adapt usages Sep 12, 2025
@syphar syphar changed the title WIP: replace separate sqlite dependency with async sqlx-sqlite, adapt usages replace separate sqlite dependency with async sqlx-sqlite, adapt usages Sep 12, 2025
@syphar syphar marked this pull request as ready for review September 12, 2025 13:07
@syphar syphar requested a review from a team as a code owner September 12, 2025 13:07
@GuillaumeGomez
Copy link
Member

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit b00825f into rust-lang:master Sep 18, 2025
10 checks passed
@GuillaumeGomez GuillaumeGomez deleted the remove-rusqlite branch September 18, 2025 20:31
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants