Emit canonical URLs for all rustdoc pages #1792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
syphar
reviewed
Aug 11, 2022
jyn514
reviewed
Aug 11, 2022
Previously, we did not emit canonical URLs for crates that had an alternate documentation URL. However, this produces bad results for those crates, with older versions being selected as canonical even if the latest version uses docs.rs as its documentation URL.
jsha
force-pushed
the
canonical-for-all
branch
from
9c81a2f to
ebaf774
Compare
|
Ping on this? :-) |
syphar
approved these changes
Aug 26, 2022
|
LGTM, sorry for the delay |
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we did not emit canonical URLs for crates that had an alternate documentation URL. However, this produces bad results for those crates, with older versions being selected as canonical even if the latest version uses docs.rs as its documentation URL.
Part of #74