Fix "Invited by" column #7982
Merged
Fix "Invited by" column #7982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `normalizeResponse()` implementation was throwing away the `users` array in the payload, because of a "missing id" issue (see rust-lang#3490). The root cause for that however was not that the `id` field in the `user` objects was missing (it actually exists), but that the `modelNameFromPayloadKey()` implementation was unconditionally returning `'crate-owner-invite'` even for `user` payloads. This change fixes the `modelNameFromPayloadKey()` implementation to be compatible with `user` payloads and removes the now obsolete `normalizeResponse()` implementation.
…ited_by_username` field `invited_by_username` isn't actually sent anymore by the v2 (aka. `private`) API and it had been showing an empty column for 14 months now... 😅
`invited_by_username` isn't actually sent anymore by the v2 (aka. `private`) API and it had been showing an empty column for 14 months now... 😅
LawnGnome
approved these changes
Jan 22, 2024
*Ember Data 😉 |
See how blissful I am? (The funny part is that I actually wrote Ember Data to start with, then Googled it, and convinced myself it was just part of Ember.) |
|
Hahaha, it is an official package, but it's optional and you can just as well use fetch directly or GraphQL or whatever :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Invited by" column on https://crates.io/me/pending-invites has not shown any content for the past 14 months (since #5501 was merged and deployed).
When working on the migration back then, I missed that the new API endpoint does not contain the
invited_by_usernamefield anymore, but our frontend template was still using that field.This PR removes the
invited_by_usernamefield from the corresponding Ember Data model and replaces it with theinviterandinviteerelationships, which are then used to display the inviter name on https://crates.io/me/pending-invites.Best reviewed commit-by-commit.