tests: define assert_forbidden and assert_not_found for any response
#6585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing uses of these functions meant that uses of `get` and `post` didn't have to explicitly turbofish into `()`, but defining them this way means they can't be used on other responses (for example, the ones returned from `yank` and `unyank`). Moving the definitions into `Response<T>` means we can now use these assertion helpers on any response type, at the cost of having some more turbofish.
LawnGnome
added
the
C-internal 🔧
Turbo87
approved these changes
Jun 8, 2023
|
since #6811 was closed I suppose we can close this one too? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing uses of these functions meant that uses of
getandpostdidn't have to explicitly turbofish into(), but defining them this way means they can't be used on other responses (for example, the ones returned fromyankandunyank). Moving the definitions intoResponse<T>means we can now use these assertion helpers on any response type, at the cost of having some more turbofish.(This is obviously a prep PR for the PR I'll be opening Real Soon Now for the
admin-minininjabranch. The more I can move out of that PR, the better.)