Skip to content

database/api_tokens: Add crate_scopes and endpoint_scopes columns #5562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 30, 2022

This is the very first basic step in implementing #5443. The PR just adds the two crate_scopes and endpoint_scopes columns to the database with a Option<Vec<String>> on the Rust side. A follow-up PR will then migrate the Rust side to more specific types (see #5528).

This is PR is as small as possible to reduce the need for a revert with a database migration involved.

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-backend ⚙️ labels Nov 30, 2022
@Turbo87 Turbo87 mentioned this pull request Nov 30, 2022
7 tasks
@Turbo87
Copy link
Member Author

Turbo87 commented Dec 1, 2022

checked this on our staging environment and everything still appears to work well

@Turbo87 Turbo87 merged commit 3acb400 into rust-lang:master Dec 1, 2022
@Turbo87 Turbo87 deleted the token-scope-columns branch December 1, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant