Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use new endpoint for crate owner invites #5389

Closed
wants to merge 1 commit into from

Conversation

LeoBorai
Copy link
Contributor

@LeoBorai LeoBorai commented Oct 28, 2022

Provides implementation on seek pagination for Pending Owner Invites page.

Previously on: #5185

@LeoBorai LeoBorai marked this pull request as draft October 28, 2022 05:11
@Turbo87
Copy link
Member

Turbo87 commented Nov 20, 2022

I just realized that there is already an implementation for that route handler and I just forgot about it... 🤦‍♂️

see https://github.com/rust-lang/crates.io/blob/59e4fd4ab2be9f37c40f7beb536415dda81d2125/mirage/route-handlers/invites.js 😅

sorry for the back and forth. I think with this out of the way the next step would be to switch the existing Ember Data code over to using the new endpoint instead.

since this PR was AFAIU only about adding the mirage endpoint I'll go ahead and close it until we have a PR that updates the Ember Data code :)

@Turbo87 Turbo87 closed this Nov 20, 2022
@Turbo87
Copy link
Member

Turbo87 commented Nov 20, 2022

sorry, I meant to close #5397 instead 😅

@Turbo87 Turbo87 reopened this Nov 20, 2022
@bors
Copy link
Contributor

bors commented Nov 20, 2022

☔ The latest upstream changes (presumably 4a50f98) made this pull request unmergeable. Please resolve the merge conflicts.

@LeoBorai LeoBorai closed this Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants