Skip to content

Adding categories related to Aerospace #4400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

elpiel
Copy link
Contributor

@elpiel elpiel commented Jan 2, 2022

Resolves #4105

I've also added the category Software-defined radio.
Here are 2 crates that are in this category:

- https://github.com/rsadsb/adsb_deku
- https://github.com/FutureSDR/FutureSDR

I can remove the SDR from this PR if it's necessary to discuss it first at a meeting @Turbo87.

The Software-defined radio category was removed from this PR.

CC @wcampbell0x2a @bastibl @MoralCode

@Turbo87
Copy link
Member

Turbo87 commented Jan 3, 2022

I can remove the SDR from this PR if it's necessary to discuss it first at a meeting @Turbo87.

yeah, let's move that out of the PR to unblock the others. I'm not sure yet about a top-level SDR category or whether we should rather move it into "Science" for example. It seems like a very specific one and I'm wondering if there is a way to generalize it a bit more.

@Turbo87 Turbo87 added A-backend ⚙️ A-categories C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works labels Jan 3, 2022
@elpiel elpiel force-pushed the issue-4105-adding-more-categories branch from 867d3c1 to a2f2185 Compare January 3, 2022 08:41
@elpiel
Copy link
Contributor Author

elpiel commented Jan 3, 2022

I can remove the SDR from this PR if it's necessary to discuss it first at a meeting @Turbo87.

yeah, let's move that out of the PR to unblock the others. I'm not sure yet about a top-level SDR category or whether we should rather move it into "Science" for example. It seems like a very specific one and I'm wondering if there is a way to generalize it a bit more.

Ok, it's removed. Thank you!

@Turbo87
Copy link
Member

Turbo87 commented Jan 3, 2022

Thanks! :)

@bors r+

@bors
Copy link
Contributor

bors commented Jan 3, 2022

📌 Commit a2f2185 has been approved by Turbo87

@bors
Copy link
Contributor

bors commented Jan 3, 2022

⌛ Testing commit a2f2185 with merge fff03bc...

@elpiel
Copy link
Contributor Author

elpiel commented Jan 3, 2022

Thanks! :)

@bors r+

No, thank you!
Happy 2022 😋

@bors
Copy link
Contributor

bors commented Jan 3, 2022

☀️ Test successful - checks-actions
Approved by: Turbo87
Pushing fff03bc to master...

@bors bors merged commit fff03bc into rust-lang:master Jan 3, 2022
@Turbo87
Copy link
Member

Turbo87 commented Jan 3, 2022

https://crates.io/categories/aerospace

have fun 😉

@MoralCode
Copy link

I'm not sure yet about a top-level SDR category or whether we should rather move it into "Science" for example. It seems like a very specific one and I'm wondering if there is a way to generalize it a bit more.

is there already a Radio or RF or Electromagnetic Spectrum type categories? it seems like those might be some appropriate categories to put SDR underneath (in order of increasing generality)

@Turbo87
Copy link
Member

Turbo87 commented Jan 3, 2022

@MoralCode the current set of categories is defined at https://github.com/elpiel/crates.io/blob/master/src/boot/categories.toml

@MoralCode
Copy link

ah yeah I saw that, what I meant was those could be some possible names for generalizations of an SDR category if they don't already exist

@elpiel
Copy link
Contributor Author

elpiel commented Jan 3, 2022

ah yeah I saw that, what I meant was those could be some possible names for generalizations of an SDR category if they don't already exist

Maybe start a new issues to add more categories if you have an idea how they can look?
I'm also not entirely sure about the separation of the 2 categories - Unnamed aerial vehicles & drones so I'm opened for ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ A-categories C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding more categories
4 participants