Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin ember-data to 5.3.11 #10882

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Pin ember-data to 5.3.11 #10882

merged 1 commit into from
Mar 25, 2025

Conversation

eth3lbert
Copy link
Contributor

@eth3lbert eth3lbert commented Mar 24, 2025 •
edited
Loading

ember-data 5.3.12 with all cookies disabled will produce the following errors:

Request to access cookie or storage on “http://localhost:4200/” was blocked because we are blocking all storage access requests.

Error while processing route: index The operation is insecure. @webpack://crates-io/../../.pnpm/@[email protected]/node_modules/@warp-drive/core-types/dist/runtime.js?:11:18
../../.pnpm/@[email protected]/node_modules/@warp-drive/core-types/dist/runtime.js@http://localhost:4200/assets/chunk.62e397042e3860b4cc0e.js:2427:1
__webpack_require__@http://localhost:4200/assets/chunk.6c34f435df0c2bcec442.js:31:42
@webpack://crates-io/../../.pnpm/@[email protected]_@[email protected]_@[email protected]_@warp-dri_d48323cbad6325bc586f3b5a2dc4a8ea/node_modules/@ember-data/store/dist/many-array-uP6jS6_J.js?:39:107
../../.pnpm/@[email protected]_@[email protected]_@[email protected]_@warp-dri_d48323cbad6325bc586f3b5a2dc4a8ea/node_modules/@ember-data/store/dist/many-array-uP6jS6_J.js@http://localhost:4200/assets/chunk.62e397042e3860b4cc0e.js:436:1
__webpack_require__@http://localhost:4200/assets/chunk.6c34f435df0c2bcec442.js:31:42
@webpack://crates-io/../../.pnpm/@[email protected]_@[email protected]_@[email protected]_@warp-dri_d48323cbad6325bc586f3b5a2dc4a8ea/node_modules/@ember-data/store/dist/-private.js?:30:100
../../.pnpm/@[email protected]_@[email protected]_@[email protected]_@warp-dri_d48323cbad6325bc586f3b5a2dc4a8ea/node_modules/@ember-data/store/dist/-private.js@http://localhost:4200/assets/chunk.62e397042e3860b4cc0e.js:414:1
__webpack_require__@http://localhost:4200/assets/chunk.6c34f435df0c2bcec442.js:31:42
@webpack://crates-io/../../.pnpm/@[email protected]_@[email protected]_@[email protected]_@emb_8183f4fa8df5f4623e0e8b6264edfae6/node_modules/@ember-data/graph/dist/-private.js?:9:102
../../.pnpm/@[email protected]_@[email protected]_@[email protected]_@emb_8183f4fa8df5f4623e0e8b6264edfae6/node_modules/@ember-data/graph/dist/-private.js@http://localhost:4200/assets/chunk.62e397042e3860b4cc0e.js:183:1
__webpack_require__@http://localhost:4200/assets/chunk.6c34f435df0c2bcec442.js:31:42
@webpack://crates-io/../../.pnpm/@[email protected]_8c856bc34520c6259888449deeea11d6/node_modules/@ember-data/json-api/dist/index.js?:5:102
../../.pnpm/@[email protected]_8c856bc34520c6259888449deeea11d6/node_modules/@ember-data/json-api/dist/index.js@http://localhost:4200/assets/chunk.62e397042e3860b4cc0e.js:194:1
__webpack_require__@http://localhost:4200/assets/chunk.6c34f435df0c2bcec442.js:31:42
@webpack://crates-io/../../.pnpm/[email protected]_@[email protected]_@[email protected]_@[email protected]_emb_184310f1ee2b67b3fe6803c284e82487/node_modules/ember-data/dist/store.js?:6:97
../../.pnpm/[email protected]_@[email protected]_@[email protected]_@[email protected]_emb_184310f1ee2b67b3fe6803c284e82487/node_modules/ember-data/dist/store.js@http://localhost:4200/assets/chunk.62e397042e3860b4cc0e.js:3923:1
__webpack_require__@http://localhost:4200/assets/chunk.6c34f435df0c2bcec442.js:31:42
@webpack://crates-io/./services/store.js?:5:93
./services/store.js@http://localhost:4200/assets/chunk.62e397042e3860b4cc0e.js:9379:1
__webpack_require__@http://localhost:4200/assets/chunk.6c34f435df0c2bcec442.js:31:42
@webpack://crates-io/./assets/crates-io.js?:151:136
Module.prototype.exports@http://localhost:4200/assets/vendor.js:115:32
requireModule@http://localhost:4200/assets/vendor.js:36:18
get@webpack://crates-io/../../.pnpm/[email protected][email protected]_@[email protected][email protected][email protected]_/node_modules/ember-resolver/addon/index.js?:23:23
_extractDefaultExport@webpack://crates-io/../../.pnpm/[email protected][email protected]_@[email protected][email protected][email protected]_/node_modules/ember-resolver/addon/index.js?:353:39
resolveOther@webpack://crates-io/../../.pnpm/[email protected][email protected]_@[email protected][email protected][email protected]_/node_modules/ember-resolver/addon/index.js?:166:32
resolve@webpack://crates-io/../../.pnpm/[email protected][email protected]_@[email protected][email protected][email protected]_/node_modules/ember-resolver/addon/index.js?:192:23
resolve$5@http://localhost:4200/assets/vendor.js:1536:1547
resolve@http://localhost:4200/assets/vendor.js:1469:55
resolve@http://localhost:4200/assets/vendor.js:1469:155
has$1@http://localhost:4200/assets/vendor.js:1536:1831
has@http://localhost:4200/assets/vendor.js:1506:87
proto.validateInjections@http://localhost:4200/assets/vendor.js:1536:1157
create@http://localhost:4200/assets/vendor.js:1370:244
create@http://localhost:4200/assets/vendor.js:1357:72
instantiateFactory@http://localhost:4200/assets/vendor.js:1359:113
lookup@http://localhost:4200/assets/vendor.js:1357:613
lookup@http://localhost:4200/assets/vendor.js:1326:293
lookup@http://localhost:4200/assets/vendor.js:4225:148
getInjection@http://localhost:4200/assets/vendor.js:3159:191
get/<@http://localhost:4200/assets/vendor.js:2664:26
untrack@http://localhost:4200/assets/vendor.js:1791:59
get@http://localhost:4200/assets/vendor.js:2664:8
getter@http://localhost:4200/assets/vendor.js:2243:505
beforeModel@webpack://crates-io/./routes/application.js?:78:5
runBeforeModelHook@http://localhost:4200/assets/vendor.js:10863:646
resolve/<@http://localhost:4200/assets/vendor.js:10853:1289
invokeCallback@http://localhost:4200/assets/vendor.js:4650:3550
publish@http://localhost:4200/assets/vendor.js:4650:3305
@http://localhost:4200/assets/vendor.js:18100:44
invoke@http://localhost:4200/assets/vendor.js:3544:268
flush@http://localhost:4200/assets/vendor.js:3539:7
flush@http://localhost:4200/assets/vendor.js:3558:363
_end@http://localhost:4200/assets/vendor.js:3588:70
Backburner/this._boundAutorunEnd@http://localhost:4200/assets/vendor.js:3565:84
promise callback*buildNext/<@http://localhost:4200/assets/vendor.js:3518:97
flush$1@http://localhost:4200/assets/vendor.js:3601:327
_scheduleAutorun@http://localhost:4200/assets/vendor.js:3600:1589
_ensureInstance@http://localhost:4200/assets/vendor.js:3600:1392
scheduleOnce@http://localhost:4200/assets/vendor.js:3578:287
once@http://localhost:4200/assets/vendor.js:3888:20
advanceReadiness@http://localhost:4200/assets/vendor.js:16123:620
initialize/<@webpack://crates-io/./initializers/app-hook.js?:32:43
promise callback*initialize@webpack://crates-io/./initializers/app-hook.js?:32:28
runInitializers/<@http://localhost:4200/assets/vendor.js:15526:183
Vertices.prototype.each@http://localhost:4200/assets/vendor.js:15402:328
Vertices.prototype.walk@http://localhost:4200/assets/vendor.js:15396:828
DAG.prototype.each@http://localhost:4200/assets/vendor.js:15394:69
DAG.prototype.topsort@http://localhost:4200/assets/vendor.js:15396:62
_runInitializer@http://localhost:4200/assets/vendor.js:15530:617
runInitializers@http://localhost:4200/assets/vendor.js:15526:38
_bootSync@http://localhost:4200/assets/vendor.js:16151:84
domReady@http://localhost:4200/assets/vendor.js:16095:79
_run@http://localhost:4200/assets/vendor.js:3588:912
run@http://localhost:4200/assets/vendor.js:3568:1368
run$1@http://localhost:4200/assets/vendor.js:3651:20
callback@http://localhost:4200/assets/vendor.js:16067:296
EventListener.handleEvent*waitForDOMReady@http://localhost:4200/assets/vendor.js:16067:328
init@http://localhost:4200/assets/vendor.js:16013:215
initialize@http://localhost:4200/assets/vendor.js:5884:27
create@http://localhost:4200/assets/vendor.js:6262:89
@webpack://crates-io/./assets/crates-io.js?:1107:184
./assets/crates-io.js@http://localhost:4200/assets/chunk.62e397042e3860b4cc0e.js:6299:1
__webpack_require__@http://localhost:4200/assets/chunk.6c34f435df0c2bcec442.js:31:42
__webpack_exports__<@http://localhost:4200/assets/chunk.6c34f435df0c2bcec442.js:286:305
__webpack_require__.O@http://localhost:4200/assets/chunk.6c34f435df0c2bcec442.js:65:23
@http://localhost:4200/assets/chunk.6c34f435df0c2bcec442.js:287:53
@http://localhost:4200/assets/chunk.6c34f435df0c2bcec442.js:289:12
[ember.js:13725](http://localhost:4200/rewritten-packages/@embroider/synthesized-vendor/vendor/ember/ember.js)
DEBUG: For more advanced debugging, install the Ember Inspector from https://addons.mozilla.org/en-US/firefox/addon/ember-inspector/ [ember.js:637](http://localhost:4200/rewritten-packages/@embroider/synthesized-vendor/vendor/ember/ember.js)
Uncaught (in promise) DOMException: The operation is insecure.
    <anonymous> runtime.js:11
    pnpm chunk.62e397042e3860b4cc0e.js:2427
    __webpack_require__ chunk.6c34f435df0c2bcec442.js:31
    Ember 2
    __webpack_require__ chunk.6c34f435df0c2bcec442.js:31
    Ember 2
    __webpack_require__ chunk.6c34f435df0c2bcec442.js:31
    Ember 2
    __webpack_require__ chunk.6c34f435df0c2bcec442.js:31
    Ember 2
    __webpack_require__ chunk.6c34f435df0c2bcec442.js:31
    Ember 2
    __webpack_require__ chunk.6c34f435df0c2bcec442.js:31
    <anonymous> store.js:5
    js chunk.62e397042e3860b4cc0e.js:9379
    __webpack_require__ chunk.6c34f435df0c2bcec442.js:31
    <anonymous> crates-io.js:151
    exports loader.js:106
    requireModule loader.js:27
    Ember 21
    beforeModel application.js:78
    Ember 17
    initialize app-hook.js:32
    promise callback*initialize app-hook.js:32
    Ember 17
    <anonymous> crates-io.js:1107
    js chunk.62e397042e3860b4cc0e.js:6299
    __webpack_require__ chunk.6c34f435df0c2bcec442.js:31
    __webpack_exports__ chunk.6c34f435df0c2bcec442.js:286
    O chunk.6c34f435df0c2bcec442.js:65
    <anonymous> chunk.6c34f435df0c2bcec442.js:287
    <anonymous> chunk.6c34f435df0c2bcec442.js:289

Pin it to 5.3.11 to resolve #10881.

@eth3lbert eth3lbert added C-bug 🐞 Category: unintended, undesired behavior A-frontend 🐹 dependencies Pull requests that update a dependency file labels Mar 24, 2025
@Turbo87 Turbo87 merged commit 4bac42d into rust-lang:main Mar 25, 2025
10 checks passed
@Turbo87
Copy link
Member

Turbo87 commented Mar 25, 2025

can you report this upstream so that we have a chance of not being stuck on the old version? 🙏

@Turbo87 Turbo87 mentioned this pull request Mar 25, 2025
Closed
1 task
@eth3lbert eth3lbert deleted the revert-ember-data branch March 25, 2025 10:59
@eth3lbert
Copy link
Contributor Author

can you report this upstream so that we have a chance of not being stuck on the old version? 🙏

Yeah, sure, no problem! And I think I've found the culprit, which is one of the underlying internal packages core-types, that operates on sessionStorage globally. See emberjs/data@c88fd2c. If this operation is wrapped in a try-catch block, then everything works fine again!

@eth3lbert
Copy link
Contributor Author

eth3lbert commented Mar 25, 2025 •
edited
Loading

Reported at:

Proposed fixes:

@eth3lbert
Copy link
Contributor Author

Per emberjs/data#9784 (comment), this should be fixed in the next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crates.io no longer works when site local storage is blocked
2 participants
@eth3lbert @Turbo87