Implement dynamic OpenGraph image url support for crate pages #10464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdoordt
force-pushed
the
main
branch
7 times, most recently
from
27b2101 to
1c92824
Compare
Turbo87
reviewed
Feb 3, 2025
hdoordt
force-pushed
the
main
branch
5 times, most recently
from
e45d62a to
77fbee2
Compare
…l middleware, add .png extension to generated OG image URL
If `OG_IMAGE_BASE_URL` is not set we can fall back to the default image instead of using `.unwrap()` and assuming that the option is always set.
Turbo87
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related discussion: #9928
I replaced
tower_http::services::ServeFilewith a manually built response, and attempted to mimic its behavior. Furthermore, I replaced the hard coded open graph image url fromapp/index.htmlwith a Jinja2 variable calledog_image_url. I imagine this file is served from a bucket or the like in production, so upon deployment that variable should be replaced with the original fallback URL.The base URL of the OG images is configurable, and should work with either a local or public instance of
og-loc, or, as suggested in the related discussion, a file in a bucket.Is this going in the right direction?
To do:
moka