Test building custom targets and resolve an issue probing rustc
#970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
force-pushed
the
fix-custom-target
branch
3 times, most recently
from
9ca7153 to
2fbd5c9
Compare
tgross35
changed the title
tgross35
changed the title
rustc
tgross35
force-pushed
the
fix-custom-target
branch
from
2fbd5c9 to
5ccd53c
Compare
The `rustc` probe done in our build scripts needs to pass `--target` to get the correct configuration, which usually comes from the `TARGET` environment variable. However, for targets specified via a `target.json` file, `TARGET` gets set to the file name without an extension or path. `rustc` will check a search path to attempt to locate the file, but this is likely to fail since the directory where Cargo invokes build scripts (and hence where those scripts invoke `rustc`) might not have any relation to the JSON spec file. Resolve this for now by leaving `f16` and `f128` disabled if the `rustc` command fails. Result of the discussion at CARGO-14208 may eventually provide a better solution. A CI test is also added since custom JSON files are an edge case that could fail in other ways. I verified this fails without the fix here. The JSON file is the output for `thumbv7em-none-eabi`, just renamed so `rustc` doesn't identify it.
tgross35
force-pushed
the
fix-custom-target
branch
from
5ccd53c to
8aba4c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rustcprobe done in our build scripts needs to pass--targettoget the correct configuration, which usually comes from the
TARGETenvironment variable. However, for targets specified via a
target.jsonfile,
TARGETgets set to the file name without an extension or path.rustcwill check a search path to attempt to locate the file, but thisis likely to fail since the directory where Cargo invokes build scripts
(and hence where those scripts invoke
rustc) might not have anyrelation to the JSON spec file.
Resolve this for now by leaving
f16andf128disabled if therustccommand fails. Result of the discussion at CARGO-14208 may eventually
provide a better solution.
A CI test is also added since custom JSON files are an edge case that
could fail in other ways. I verified this fails without the fix here.
The JSON file is the output for
thumbv7em-none-eabi, just renamed sorustcdoesn't identify it.