Skip to content

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Oct 10, 2025

cfg(target_family = "...") can be set multiple times, and thus CARGO_CFG_TARGET_FAMILY can also contain comma-separated values, similar to CARGO_CFG_TARGET_FEATURE.

This allows cargo build --target wasm32-unknown-emscripten -p musl-math-sys to work, and will become more important if we were to add e.g. cfg(target_family = "darwin") in the future as discussed in rust-lang/rust#100343.

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like loongarch features changed and half needs to update, I'll look into that later.

@tgross35 tgross35 enabled auto-merge (squash) October 22, 2025 08:48
@tgross35 tgross35 force-pushed the cfg_target_family_multi_valued branch from 566b2fd to 99ea0a9 Compare October 22, 2025 08:49
@tgross35 tgross35 merged commit eba1a3f into rust-lang:master Oct 22, 2025
38 checks passed
@madsmtm madsmtm deleted the cfg_target_family_multi_valued branch October 22, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants