add Copy, Clone and Drop traits support
#385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
approved these changes
Apr 13, 2020
|
|
||
| match db.trait_datum(impl_datum.trait_id()).well_known? { | ||
| // You can't add a manual implementation of Sized | ||
| WellKnownTrait::SizedTrait => Some(GoalData::CannotProve(()).intern(interner)), |
There was a problem hiding this comment.
This seems like it will ultimately have to change, since the resulting UX would be terrible, no?
There was a problem hiding this comment.
By UX you mean writing tests and using repl?
There was a problem hiding this comment.
CannotProve is not the best way to report errors, but it I guess we'll change that when we add proper error reporting
There was a problem hiding this comment.
By UX I mean "when rustc runs this code" -- the vision eventually is that rustc will run these WF goals and report errors from the results. But I agree we can address it later.
jackh726
reviewed
Apr 14, 2020
nikomatsakis
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I raised some concerns about this implementation in this zulip thread, how grounded are they?
cc #363