add Sized well-known impl and wf check #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
requested changes
Apr 6, 2020
| WellKnownTrait::CopyTrait => { /* TODO */ } | ||
| WellKnownTrait::CloneTrait => { /* TODO */ } | ||
| } | ||
| } | ||
|
|
||
| fn add_sized_program_clauses<I: Interner>( |
There was a problem hiding this comment.
I think we should make builtin_traits/sized.rs and put this function in there
|
|
||
| let struct_datum = db.struct_datum(struct_id); | ||
|
|
||
| if struct_datum.binders.map_ref(|b| b.fields.is_empty()).value { |
There was a problem hiding this comment.
Comment:
Structs with no fields are always Sized
| return; | ||
| } | ||
|
|
||
| let last_field_ty = struct_datum |
There was a problem hiding this comment.
Let's add a comment here -- something like this:
To check if a struct type S<..> is Sized, we only have to look at its last field. This is because the WF checks for structs require that all the other fields must be Sized.
|
Addressed the nits and rebased |
nikomatsakis
requested changes
Apr 7, 2020
|
All done and rebased |
nikomatsakis
approved these changes
Apr 7, 2020
|
@nikomatsakis wait, why did I put the constraint check into the WfSolver? It should probably be in ToProgramClauses for StructDatum, right? |
|
made a zulip thread because I have many questions about this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: doesnt actually close \#261, we need #368 to land first and address it