Flounder if truncation would happen #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
approved these changes
Jan 26, 2020
|
@jackh726 this looks very good -- it needs rebase though. Ping me if you get a chance for that. |
…table as floundered and don't return an answer
jackh726
force-pushed
the
truncate_flounder
branch
from
2b99172 to
30f9d12
Compare
|
🤦♂️because I corrected a typo in the other PR. @nikomatsakis rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #301 (this is caused by bad truncation)
cc. #302 (should fix many known cases of this, but theoretically the problem still exists)
cc. #318 (needs more investigation)
This keeps all existing truncation code intact, just doesn't use the resulting substs or goals. But could change it to short-circuit to a bool.
Could add some documentation to
abstract_*_literalto explain why we discard the goal if it would get truncated, but overall changes are pretty minimal/complete.