Skip to content

Update stacker to 0.1.5 #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Conversation

memoryruins
Copy link
Contributor

Checked in on #169 after a recent stacker update:

Before the most recent stacker changes, I received a variation of the following error when running debug cargo test on a Windows machine :

failures:

---- rules::wf::test::higher_ranked_cyclic_requirements stdout ----
thread 'rules::wf::test::higher_ranked_cyclic_requirements' panicked at 'attempt to subtract with overflow', C:\Users\Michael\.cargo\registry\src\github.com-1ecc6299db9ec823\stacker-0.1.3\src\lib.rs:79:9
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

---- test::slg::subgoal_abstraction stdout ----
program {
trait Foo {  } struct Box < T > {  } impl < T > Foo for T where Box < T > :
Foo {  } }
----------------------------------------------------------------------
goal { exists < T > { T : Foo } }
thread 'test::slg::subgoal_abstraction' panicked at 'attempt to subtract with overflow', C:\Users\Michael\.cargo\registry\src\github.com-1ecc6299db9ec823\stacker-0.1.3\src\lib.rs:79:9


failures:
    rules::wf::test::higher_ranked_cyclic_requirements
    test::slg::subgoal_abstraction

test result: FAILED. 139 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '--lib'

After updating stacker from 0.1.2/0.1.3 to 0.1.5, all tests pass on debug.

Travis CI's Windows support is still in early release https://docs.travis-ci.com/user/reference/windows/, so if its desired to add Windows to CI before its stable, it should probably be set to allow-fail at first.

@rust-highfive
Copy link

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@nikomatsakis
Copy link
Contributor

@bors r+

@nikomatsakis
Copy link
Contributor

cc @oli-obk, @nagisa, @alexcrichton, just because this is related to stacker and maybe you know something I don't =)

@nikomatsakis
Copy link
Contributor

Um I forgot bors isn't active here apparently =)

@nikomatsakis nikomatsakis merged commit 943f941 into rust-lang:master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants