Refactor RustcTargetData to do lazy loading of targets information #9049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Without diving into the depths of this refactoring, which unfortunately I don't have time for right now, I can't really help much personally taking this to a full-working state. |
|
Got it, thank you for both this and your comment on the other PR! I'll close this and go with the “add something that allows adding kinds as they appear” route, as it looks like it can create a much better API than sparkling IO access and fallibility literally everywhere :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I gave up midway through this refactoring, it looks way too big for what it's supposed to do.
More discussion on what to actually do will probably be available at #9030 (comment)