Skip to content

Revert "Auto merge of #5461 - matklad:meta-rename, r=alexcrichton" #5577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2018

Conversation

matklad
Copy link
Member

@matklad matklad commented May 27, 2018

This reverts commit d0d3cb5, reversing
changes made to 757112c.

It is not clear that the design is right, see
#5558 (comment)

this is the backport sibling of #5576

…chton"

This reverts commit d0d3cb5, reversing
changes made to 757112c.

It is not clear that the design is right, see
rust-lang#5558 (comment)
@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.27.0. Please double check that you specified the right target!

@alexcrichton
Copy link
Member

@bors: r+

@matklad mind reopening the referenced issues?

@bors
Copy link
Contributor

bors commented May 27, 2018

📌 Commit 1310069 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented May 27, 2018

⌛ Testing commit 1310069 with merge 1e95190...

bors added a commit that referenced this pull request May 27, 2018
Revert "Auto merge of #5461 - matklad:meta-rename, r=alexcrichton"

This reverts commit d0d3cb5, reversing
changes made to 757112c.

It is not clear that the design is right, see
#5558 (comment)

this is the backport sibling of #5576
@bors
Copy link
Contributor

bors commented May 27, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 1e95190 to rust-1.27.0...

@bors bors merged commit 1310069 into rust-lang:rust-1.27.0 May 27, 2018
@matklad matklad deleted the revert-deps-beta branch May 28, 2018 08:40
@matklad
Copy link
Member Author

matklad commented May 28, 2018

Reopened a meta issue for it at #5583

ehuss added a commit to ehuss/rust that referenced this pull request Jun 12, 2018
- rust-lang/cargo#5577 - revert rust-lang/cargo#5461 (Support crate renames in `cargo metadata`)
- rust-lang/cargo#5567 - Copy `--all-features` request to all workspace members
bors added a commit to rust-lang/rust that referenced this pull request Jun 12, 2018
[BETA] Update Cargo

- rust-lang/cargo#5577 - revert rust-lang/cargo#5461 (Support crate renames in `cargo metadata`)
- rust-lang/cargo#5567 - Copy `--all-features` request to all workspace members
@ehuss ehuss added this to the 1.27.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants