Accept default_features for default-features
#3771
Conversation
This was accepted by this historical TOML parser, so we'll need to preserve this ability. Closes rust-lang#3768
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @matklad |
|
Was this because Line 228 in 79c743a I wonder if Serde has a specific option for this, to avoid duplicating every field? |
Sure! But we still need to fix other instances I think. Perhaps even run a crater with serde-based Cargo? @bors: r+ |
|
📌 Commit fd25593 has been approved by |
Accept `default_features` for `default-features` This was accepted by this historical TOML parser, so we'll need to preserve this ability. Closes #3768
That would be nice. |
|
@matklad yeah the old rustc-serialize implementation would try both, returning whichever succeeded first. My plan is to sort of just fix these up as they come in, but yes I would also like to schedule a crater run to happen now that this moved into nightlies to assess the breakage. |
|
☀️ Test successful - status-appveyor, status-travis |
I kinda feel that maybe it's better to fix them upfront? grepping local |
|
@matklad ah yeah I just don't know how much to fix! Ideally we wouldn't have to fix any... I'll send a PR for that and build-dependencies though |
It is intended that `-` is used in multi-word Cargo.toml keys. `_` was historically accepted and is not going away, but let's use `-` just in case. See rust-lang/cargo#3771
|
Found more more affected package: It's |
It is intended that `-` is used in multi-word Cargo.toml keys. `_` was historically accepted and is not going away, but let's use `-` just in case. See rust-lang/cargo#3771
This was accepted by this historical TOML parser, so we'll need to preserve this
ability.
Closes #3768