Skip to content

refactor: Migrate some cases to expect/reason #16461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
epage merged 1 commit into from
Jan 5, 2026
Merged

refactor: Migrate some cases to expect/reason #16461

epage merged 1 commit into from
Jan 5, 2026

Conversation

@epage
Copy link
Contributor

@epage epage commented Jan 2, 2026

What does this PR try to resolve?

Thought of this when reviewing new cases for std::env in #16131.

How to test and review this PR?

@epage
refactor: Migrate some cases to expect/reason
91fbe9f 
Thought of this when reviewing new cases for `std::env` in rust-lang#16131.
@rustbot
Copy link
Collaborator

rustbot commented Jan 2, 2026

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-build-scripts Area: build.rs scripts A-cli Area: Command-line interface, option parsing, etc. A-configuration Area: cargo config files and env vars A-console-output Area: Terminal output, colors, progress bar, etc. A-environment-variables Area: environment variables A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. A-unstable Area: nightly unstable support Command-fix Command-new Command-tree S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2026
@epage epage mentioned this pull request Jan 2, 2026
Draft
weihanglo
weihanglo approved these changes Jan 2, 2026
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge with or without the nit.

View changes since this review

@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2026

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@epage epage enabled auto-merge January 5, 2026 14:25
weihanglo
weihanglo reviewed Jan 5, 2026
View reviewed changes
@epage epage disabled auto-merge January 5, 2026 14:40
@epage epage enabled auto-merge January 5, 2026 14:40
@epage epage added this pull request to the merge queue Jan 5, 2026
Merged via the queue into rust-lang:master with commit 150e4b8 Jan 5, 2026
29 checks passed
@epage epage deleted the expect branch January 5, 2026 15:46
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 5, 2026
@weihanglo weihanglo mentioned this pull request Jan 6, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@weihanglo weihanglo

Labels

A-build-scripts Area: build.rs scripts A-cli Area: Command-line interface, option parsing, etc. A-configuration Area: cargo config files and env vars A-console-output Area: Terminal output, colors, progress bar, etc. A-environment-variables Area: environment variables A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. A-unstable Area: nightly unstable support Command-fix Command-new Command-tree

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@epage @rustbot @weihanglo