Fix: correctly pluralize 'target'/'targets' in finished message #16132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-build-execution
weihanglo
reviewed
Oct 20, 2025
| ); | ||
| let target_count = self.counts.len(); | ||
| let message = format!( | ||
| "{profile_link}`{profile_name}` profile [{opt_type}]{profile_link:#} target(s) in {time_elapsed}", |
There was a problem hiding this comment.
This message is emitted in every build command, and changing this failed 960 tests. To fix them we then need to update snapshots in those 960 tests. I am not sure if it is worthy.
| let profile_link = build_runner.bcx.gctx.shell().err_hyperlink( | ||
| "https://doc.rust-lang.org/cargo/reference/profiles.html#default-profiles", | ||
| ); | ||
| let target_count = self.counts.len(); |
There was a problem hiding this comment.
This seems wrong as it counted every package in the dependency graph, not just selected local packages.
This change ensures that the finished message correctly uses "target" or "targets"
based on the number of targets built, improving clarity in multi-target builds.
However, maybe the question should be asked like: What do we really want to count here? What does target(s) mean here really?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that the finished message correctly uses "target" or "targets"
based on the number of targets built, improving clarity in multi-target builds.